b87f1b22a8
This commit: - Introduces a new `InParallelOpInterface`, along with the `ParallelCombiningOpInterface`, represent the parallel updating operations we have in a parallel loop of `scf.forall`. - Change the name of `ParallelCombiningOpInterface` to `InParallelOpInterface` as the naming was quite confusing. - `ParallelCombiningOpInterface` now is used to generalize operations that insert into shared tensors within parallel combining regions. Previously, only `tensor.parallel_insert_slice` was supported directly in `scf.InParallelOp` regions. - `tensor.parallel_insert_slice` now implements `ParallelCombiningOpInterface`. This change enables future extensions to support additional parallel combining operations beyond `tensor.parallel_insert_slice`, which have different update semantics, so the `in_parallel` region can correctly and safely represent these kinds of operation without potential mistakes such as races. Author credits: @qedawkins
28 lines
1.1 KiB
C++
28 lines
1.1 KiB
C++
//===- ParallelCombiningOpInterface.cpp - Parallel combining op interface -===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Interfaces/ParallelCombiningOpInterface.h"
|
|
|
|
using namespace mlir;
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// InParallelOpInterface (formerly ParallelCombiningOpInterface)
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// TODO: Single region single block interface on interfaces ?
|
|
LogicalResult mlir::detail::verifyInParallelOpInterface(Operation *op) {
|
|
if (op->getNumRegions() != 1)
|
|
return op->emitError("expected single region op");
|
|
if (!op->getRegion(0).hasOneBlock())
|
|
return op->emitError("expected single block op region");
|
|
return success();
|
|
}
|
|
|
|
/// Include the definitions of the interface.
|
|
#include "mlir/Interfaces/ParallelCombiningOpInterface.cpp.inc"
|