This patch extends the Math-to-EmitC conversion to cover `math.roundeven` and `math.sqrt` for scalar f32/f64 values. `math.roundeven` and `math.sqrt` are lowered to `emitc.call_opaque` using the appropriate target-specific names: C: `roundevenf` / `roundeven`, `sqrtf` / `sqrt` C++: `std::roundeven`, `std::sqrt` The patch also adds coverage for `math.rsqrt`. There is no direct EmitC lowering for `math.rsqrt`; instead, the new tests verify the existing expansion path through `-math-expand-ops=ops=rsqrt`, followed by `-convert-math-to-emitc` and `-convert-arith-to-emitc`. This ensures the cross-dialect lowering sequence produces the expected `emitc.constant`, `emitc.call_opaque`, and `emitc.div` operations for f32/f64. Unsupported cases remain unchanged. In particular, the new test documents that f16 math.rsqrt is not lowered because math.sqrt is only converted for f32/f64.
90 lines
4.2 KiB
C++
90 lines
4.2 KiB
C++
//===- MathToEmitC.cpp - Math to EmitC Patterns -----------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Conversion/MathToEmitC/MathToEmitC.h"
|
|
|
|
#include "mlir/Dialect/EmitC/IR/EmitC.h"
|
|
#include "mlir/Dialect/Math/IR/Math.h"
|
|
#include "mlir/Transforms/DialectConversion.h"
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
template <typename OpType>
|
|
class LowerToEmitCCallOpaque : public OpRewritePattern<OpType> {
|
|
std::string calleeStr;
|
|
emitc::LanguageTarget languageTarget;
|
|
|
|
public:
|
|
LowerToEmitCCallOpaque(MLIRContext *context, std::string calleeStr,
|
|
emitc::LanguageTarget languageTarget)
|
|
: OpRewritePattern<OpType>(context), calleeStr(std::move(calleeStr)),
|
|
languageTarget(languageTarget) {}
|
|
|
|
LogicalResult matchAndRewrite(OpType op,
|
|
PatternRewriter &rewriter) const override;
|
|
};
|
|
|
|
template <typename OpType>
|
|
LogicalResult LowerToEmitCCallOpaque<OpType>::matchAndRewrite(
|
|
OpType op, PatternRewriter &rewriter) const {
|
|
if (!llvm::all_of(op->getOperandTypes(),
|
|
llvm::IsaPred<Float32Type, Float64Type>) ||
|
|
!llvm::all_of(op->getResultTypes(),
|
|
llvm::IsaPred<Float32Type, Float64Type>))
|
|
return rewriter.notifyMatchFailure(
|
|
op.getLoc(),
|
|
"expected all operands and results to be of type f32 or f64");
|
|
std::string modifiedCalleeStr = calleeStr;
|
|
if (languageTarget == emitc::LanguageTarget::cpp11) {
|
|
modifiedCalleeStr = "std::" + calleeStr;
|
|
} else if (languageTarget == emitc::LanguageTarget::c99) {
|
|
auto operandType = op->getOperandTypes()[0];
|
|
if (operandType.isF32())
|
|
modifiedCalleeStr = calleeStr + "f";
|
|
}
|
|
rewriter.replaceOpWithNewOp<emitc::CallOpaqueOp>(
|
|
op, op.getType(), modifiedCalleeStr, op->getOperands());
|
|
return success();
|
|
}
|
|
|
|
} // namespace
|
|
|
|
// Populates patterns to replace `math` operations with `emitc.call_opaque`,
|
|
// using function names consistent with those in <math.h>.
|
|
void mlir::populateConvertMathToEmitCPatterns(
|
|
RewritePatternSet &patterns, emitc::LanguageTarget languageTarget) {
|
|
auto *context = patterns.getContext();
|
|
patterns.insert<LowerToEmitCCallOpaque<math::FloorOp>>(context, "floor",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::RoundOp>>(context, "round",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::RoundEvenOp>>(
|
|
context, "roundeven", languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::ExpOp>>(context, "exp",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::CosOp>>(context, "cos",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::SinOp>>(context, "sin",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::AcosOp>>(context, "acos",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::AsinOp>>(context, "asin",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::Atan2Op>>(context, "atan2",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::CeilOp>>(context, "ceil",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::AbsFOp>>(context, "fabs",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::PowFOp>>(context, "pow",
|
|
languageTarget);
|
|
patterns.insert<LowerToEmitCCallOpaque<math::SqrtOp>>(context, "sqrt",
|
|
languageTarget);
|
|
}
|