b8618ff61e
When evaluating whether an allocated type contains a pointer to generate the `alloc_token` metadata, `typeContainsPointer` incorrectly stopped recursion upon encountering an `AtomicType`. This resulted in types like `_Atomic(int *)` (or `std::atomic<int *>` under libc++) being incorrectly evaluated as not containing a pointer. Add support for `AtomicType` in `typeContainsPointer` by recursively checking the contained type. Add tests for structs containing `_Atomic(int *)` and `_Atomic(int)`.
220 lines
8.4 KiB
C++
220 lines
8.4 KiB
C++
// RUN: %clang_cc1 -fsanitize=alloc-token -triple x86_64-linux-gnu -std=c++20 -emit-llvm -disable-llvm-passes %s -o - | FileCheck %s
|
|
|
|
#include "../Analysis/Inputs/system-header-simulator-cxx.h"
|
|
|
|
typedef __UINTPTR_TYPE__ uintptr_t;
|
|
|
|
extern "C" {
|
|
void *malloc(size_t size) __attribute__((malloc));
|
|
}
|
|
|
|
void *sink; // prevent optimizations from removing the calls
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z15test_malloc_intv(
|
|
// CHECK: call noalias ptr @malloc(i64 noundef 4){{.*}} !alloc_token [[META_INT:![0-9]+]]
|
|
void *test_malloc_int() {
|
|
int *a = (int *)malloc(sizeof(int));
|
|
*a = 42;
|
|
return a;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z15test_malloc_ptrv(
|
|
// CHECK: call noalias ptr @malloc(i64 noundef 8){{.*}} !alloc_token [[META_INTPTR:![0-9]+]]
|
|
int **test_malloc_ptr() {
|
|
int **a = (int **)malloc(sizeof(int*));
|
|
*a = nullptr;
|
|
return a;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z12test_new_intv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 4){{.*}} !alloc_token [[META_INT]]
|
|
int *test_new_int() {
|
|
return new int;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z20test_new_ulong_arrayv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znam(i64 noundef 80){{.*}} !alloc_token [[META_ULONG:![0-9]+]]
|
|
unsigned long *test_new_ulong_array() {
|
|
return new unsigned long[10];
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z12test_new_ptrv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 8){{.*}} !alloc_token [[META_INTPTR]]
|
|
int **test_new_ptr() {
|
|
return new int*;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z18test_new_ptr_arrayv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znam(i64 noundef 80){{.*}} !alloc_token [[META_INTPTR]]
|
|
int **test_new_ptr_array() {
|
|
return new int*[10];
|
|
}
|
|
|
|
struct ContainsPtr {
|
|
int a;
|
|
char *buf;
|
|
};
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z27test_malloc_struct_with_ptrv(
|
|
// CHECK: call noalias ptr @malloc(i64 noundef 16){{.*}} !alloc_token [[META_CONTAINSPTR:![0-9]+]]
|
|
void *test_malloc_struct_with_ptr() {
|
|
return malloc(sizeof(ContainsPtr));
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z33test_malloc_struct_array_with_ptrv(
|
|
// CHECK: call noalias ptr @malloc(i64 noundef 160){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
void *test_malloc_struct_array_with_ptr() {
|
|
return malloc(10 * sizeof(ContainsPtr));
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z31test_malloc_with_ptr_sizeof_vari(
|
|
// CHECK: call noalias ptr @malloc(i64 noundef {{.*}}){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
void *test_malloc_with_ptr_sizeof_var(int x) {
|
|
unsigned long size = sizeof(ContainsPtr);
|
|
size *= x;
|
|
return malloc(size);
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z29test_malloc_with_ptr_castonlyv(
|
|
// CHECK: call noalias ptr @malloc(i64 noundef 4096){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
ContainsPtr *test_malloc_with_ptr_castonly() {
|
|
return (ContainsPtr *)malloc(4096);
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z32test_operatornew_struct_with_ptrv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 16){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 16){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
ContainsPtr *test_operatornew_struct_with_ptr() {
|
|
ContainsPtr *c = (ContainsPtr *)__builtin_operator_new(sizeof(ContainsPtr));
|
|
sink = ::operator new(sizeof(ContainsPtr));
|
|
return c;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z38test_operatornew_struct_array_with_ptrv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 160){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 160){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
ContainsPtr *test_operatornew_struct_array_with_ptr() {
|
|
ContainsPtr *c = (ContainsPtr *)__builtin_operator_new(10 * sizeof(ContainsPtr));
|
|
sink = ::operator new(10 * sizeof(ContainsPtr));
|
|
return c;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z33test_operatornew_struct_with_ptr2v(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 16){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 16){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
ContainsPtr *test_operatornew_struct_with_ptr2() {
|
|
ContainsPtr *c = (ContainsPtr *)__builtin_operator_new(sizeof(*c));
|
|
sink = ::operator new(sizeof(*c));
|
|
return c;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z39test_operatornew_struct_array_with_ptr2v(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 160){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 160){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
ContainsPtr *test_operatornew_struct_array_with_ptr2() {
|
|
ContainsPtr *c = (ContainsPtr *)__builtin_operator_new(10 * sizeof(*c));
|
|
sink = ::operator new(10 * sizeof(*c));
|
|
return c;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z24test_new_struct_with_ptrv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 16){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
ContainsPtr *test_new_struct_with_ptr() {
|
|
return new ContainsPtr;
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z30test_new_struct_array_with_ptrv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znam(i64 noundef 160){{.*}} !alloc_token [[META_CONTAINSPTR]]
|
|
ContainsPtr *test_new_struct_array_with_ptr() {
|
|
return new ContainsPtr[10];
|
|
}
|
|
|
|
class TestClass {
|
|
public:
|
|
void Foo();
|
|
~TestClass();
|
|
int data[16];
|
|
};
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z14test_new_classv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 64){{.*}} !alloc_token [[META_TESTCLASS:![0-9]+]]
|
|
TestClass *test_new_class() {
|
|
return new TestClass();
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z20test_new_class_arrayv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znam(i64 noundef 648){{.*}} !alloc_token [[META_TESTCLASS]]
|
|
TestClass *test_new_class_array() {
|
|
return new TestClass[10];
|
|
}
|
|
|
|
// Test that we detect that virtual classes have implicit vtable pointer.
|
|
class VirtualTestClass {
|
|
public:
|
|
virtual void Foo();
|
|
virtual ~VirtualTestClass();
|
|
int data[16];
|
|
};
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z22test_new_virtual_classv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 72){{.*}} !alloc_token [[META_VIRTUALTESTCLASS:![0-9]+]]
|
|
VirtualTestClass *test_new_virtual_class() {
|
|
return new VirtualTestClass();
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z28test_new_virtual_class_arrayv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znam(i64 noundef 728){{.*}} !alloc_token [[META_VIRTUALTESTCLASS]]
|
|
VirtualTestClass *test_new_virtual_class_array() {
|
|
return new VirtualTestClass[10];
|
|
}
|
|
|
|
// uintptr_t is treated as a pointer.
|
|
struct MyStructUintptr {
|
|
int a;
|
|
uintptr_t ptr;
|
|
};
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z18test_uintptr_isptrv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 16){{.*}} !alloc_token [[META_MYSTRUCTUINTPTR:![0-9]+]]
|
|
MyStructUintptr *test_uintptr_isptr() {
|
|
return new MyStructUintptr;
|
|
}
|
|
|
|
using uptr = uintptr_t;
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z19test_uintptr_isptr2v(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 8){{.*}} !alloc_token [[META_UINTPTR:![0-9]+]]
|
|
uptr *test_uintptr_isptr2() {
|
|
return new uptr;
|
|
}
|
|
|
|
struct StructWithAtomic {
|
|
_Atomic(int *) val;
|
|
};
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z23test_struct_with_atomicv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 8){{.*}} !alloc_token [[META_STRUCTWITHATOMIC:![0-9]+]]
|
|
StructWithAtomic *test_struct_with_atomic() {
|
|
return new StructWithAtomic;
|
|
}
|
|
|
|
struct StructWithAtomicNonPtr {
|
|
_Atomic(int) val;
|
|
};
|
|
|
|
// CHECK-LABEL: define dso_local noundef ptr @_Z30test_struct_with_atomic_nonptrv(
|
|
// CHECK: call noalias noundef nonnull ptr @_Znwm(i64 noundef 4){{.*}} !alloc_token [[META_STRUCTWITHATOMICNONPTR:![0-9]+]]
|
|
StructWithAtomicNonPtr *test_struct_with_atomic_nonptr() {
|
|
return new StructWithAtomicNonPtr;
|
|
}
|
|
|
|
// CHECK: [[META_INT]] = !{!"int", i1 false}
|
|
// CHECK: [[META_INTPTR]] = !{!"int *", i1 true}
|
|
// CHECK: [[META_ULONG]] = !{!"unsigned long", i1 false}
|
|
// CHECK: [[META_CONTAINSPTR]] = !{!"ContainsPtr", i1 true}
|
|
// CHECK: [[META_TESTCLASS]] = !{!"TestClass", i1 false}
|
|
// CHECK: [[META_VIRTUALTESTCLASS]] = !{!"VirtualTestClass", i1 true}
|
|
// CHECK: [[META_MYSTRUCTUINTPTR]] = !{!"MyStructUintptr", i1 true}
|
|
// CHECK: [[META_UINTPTR]] = !{!"unsigned long", i1 true}
|
|
// CHECK: [[META_STRUCTWITHATOMIC]] = !{!"StructWithAtomic", i1 true}
|
|
// CHECK: [[META_STRUCTWITHATOMICNONPTR]] = !{!"StructWithAtomicNonPtr", i1 false}
|