Files
llvm-project/clang/test/CIR/CodeGen/new-array-cookie.cpp
adams381 6ea383f58e [CIR] Fix array new cookie pointer arithmetic (#194927)
`initializeArrayCookie` calls `createPtrBitcast(ptr, u8PtrTy)` to get a
byte pointer into the allocation. `createPtrBitcast` wraps its argument
in `cir::PointerType`, so the result is `!cir.ptr<!cir.ptr<!u8i>>`
instead of `!cir.ptr<!u8i>`. The subsequent `cir.ptr_stride` by 8 then
advances by `8 * sizeof(ptr)` = 64 bytes instead of 8, placing the first
array element at the wrong offset. `delete[]` reads garbage from the
cookie and crashes with `free(): invalid pointer`.

Fix: `createBitcast` instead of `createPtrBitcast`, and `u8Ty` instead
of `u8PtrTy` in the `Address` constructor.
2026-04-29 15:08:26 -05:00

42 lines
1.8 KiB
C++

// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir \
// RUN: -std=c++14 -fcxx-exceptions -fexceptions %s -o %t.cir
// RUN: FileCheck --check-prefix=CIR --input-file=%t.cir %s
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-llvm \
// RUN: -std=c++14 -fcxx-exceptions -fexceptions %s -o %t-cir.ll
// RUN: FileCheck --check-prefix=LLVM --input-file=%t-cir.ll %s
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm \
// RUN: -std=c++14 -fcxx-exceptions -fexceptions %s -o %t.ll
// RUN: FileCheck --check-prefix=OGCG --input-file=%t.ll %s
struct S {
~S();
int x;
};
// Array new with a non-trivial destructor requires a cookie to store
// the element count. The cookie is 8 bytes (sizeof(size_t)) and the
// data pointer must be advanced by 8 bytes past the allocation, not
// by 8 * sizeof(ptr).
S *allocArray(int n) {
return new S[n];
}
// CIR-LABEL: @_Z10allocArrayi
// CIR: %[[ALLOC:.*]] = cir.call @_Znam
// CIR: %[[BYTE_PTR:.*]] = cir.cast bitcast %[[ALLOC]] : !cir.ptr<!void> -> !cir.ptr<!u8i>
// CIR: %[[COOKIE_CAST:.*]] = cir.cast bitcast %[[BYTE_PTR]] : !cir.ptr<!u8i> -> !cir.ptr<!u64i>
// CIR: cir.store {{.*}} %[[COOKIE_CAST]] : !u64i, !cir.ptr<!u64i>
// CIR: %[[EIGHT:.*]] = cir.const #cir.int<8> : !s32i
// CIR: %[[DATA_PTR:.*]] = cir.ptr_stride %[[BYTE_PTR]], %[[EIGHT]] : (!cir.ptr<!u8i>, !s32i) -> !cir.ptr<!u8i>
// LLVM-LABEL: @_Z10allocArrayi
// LLVM: %[[ALLOC:.*]] = call {{.*}} ptr @_Znam
// LLVM: store i64 %{{.*}}, ptr %[[ALLOC]], align 8
// LLVM: %[[DATA:.*]] = getelementptr i8, ptr %[[ALLOC]], i64 8
// OGCG-LABEL: @_Z10allocArrayi
// OGCG: %[[ALLOC:.*]] = call {{.*}} ptr @_Znam
// OGCG: store i64 %{{.*}}, ptr %[[ALLOC]], align 8
// OGCG: %[[DATA:.*]] = getelementptr inbounds i8, ptr %[[ALLOC]], i64 8