Doomhowl-Interactive/llvm-project
0
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

[Offload] Remove unnecessary maybe_unused attribute (#175855)

Browse Source 
The attribute is not necessary in the new debug messaging.
This commit is contained in:
Hansang Bae
2026-01-15 14:31:58 -06:00
committed by GitHub
parent 15b9109bc7
commit edd857aad8
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
offload/libomptarget/OpenMP/InteropAPI.cpp
View File

@@ -219,7 +219,7 @@ omp_interop_val_t *__tgt_interop_get(ident_t *LocRef, int32_t InteropType,
auto DeviceOrErr = PM->getDevice(DeviceNum); auto DeviceOrErr = PM->getDevice(DeviceNum);
if (!DeviceOrErr) { if (!DeviceOrErr) {
[[maybe_unused]] std::string ErrStr = toString(DeviceOrErr.takeError()); std::string ErrStr = toString(DeviceOrErr.takeError());
ODBG(ODT_Interface) << "Couldn't find device " << DeviceNum ODBG(ODT_Interface) << "Couldn't find device " << DeviceNum
<< " while constructing interop object: " << ErrStr; << " while constructing interop object: " << ErrStr;
return omp_interop_none; return omp_interop_none;

6
offload/libomptarget/PluginManager.cpp
View File

@@ -59,7 +59,7 @@ void PluginManager::deinit() {
continue; continue;
if (auto Err = Plugin->deinit()) { if (auto Err = Plugin->deinit()) {
[[maybe_unused]] std::string InfoMsg = toString(std::move(Err)); std::string InfoMsg = toString(std::move(Err));
ODBG(ODT_Deinit) << "Failed to deinit plugin: " << InfoMsg; ODBG(ODT_Deinit) << "Failed to deinit plugin: " << InfoMsg;
} }
Plugin.release(); Plugin.release();
@@ -73,7 +73,7 @@ bool PluginManager::initializePlugin(GenericPluginTy &Plugin) {
return true; return true;
if (auto Err = Plugin.init()) { if (auto Err = Plugin.init()) {
[[maybe_unused]] std::string InfoMsg = toString(std::move(Err)); std::string InfoMsg = toString(std::move(Err));
ODBG(ODT_Init) << "Failed to init plugin: " << InfoMsg; ODBG(ODT_Init) << "Failed to init plugin: " << InfoMsg;
return false; return false;
} }
@@ -106,7 +106,7 @@ bool PluginManager::initializeDevice(GenericPluginTy &Plugin,
auto Device = std::make_unique<DeviceTy>(&Plugin, UserId, DeviceId); auto Device = std::make_unique<DeviceTy>(&Plugin, UserId, DeviceId);
if (auto Err = Device->init()) { if (auto Err = Device->init()) {
[[maybe_unused]] std::string InfoMsg = toString(std::move(Err)); std::string InfoMsg = toString(std::move(Err));
ODBG(ODT_Init) << "Failed to init device " << DeviceId << ": " << InfoMsg; ODBG(ODT_Init) << "Failed to init device " << DeviceId << ": " << InfoMsg;
return false; return false;
} }

6
offload/plugins-nextgen/common/src/PluginInterface.cpp
View File

@@ -1656,7 +1656,7 @@ int32_t GenericPluginTy::is_initialized() const { return Initialized; }
int32_t GenericPluginTy::isPluginCompatible(StringRef Image) { int32_t GenericPluginTy::isPluginCompatible(StringRef Image) {
auto HandleError = [&](Error Err) -> bool { auto HandleError = [&](Error Err) -> bool {
[[maybe_unused]] std::string ErrStr = toString(std::move(Err)); std::string ErrStr = toString(std::move(Err));
ODBG(OLDT_Init) << "Failure to check validity of image " << Image.data() ODBG(OLDT_Init) << "Failure to check validity of image " << Image.data()
<< ": " << ErrStr; << ": " << ErrStr;
return false; return false;
@@ -1685,7 +1685,7 @@ int32_t GenericPluginTy::isPluginCompatible(StringRef Image) {
int32_t GenericPluginTy::isDeviceCompatible(int32_t DeviceId, StringRef Image) { int32_t GenericPluginTy::isDeviceCompatible(int32_t DeviceId, StringRef Image) {
auto HandleError = [&](Error Err) -> bool { auto HandleError = [&](Error Err) -> bool {
[[maybe_unused]] std::string ErrStr = toString(std::move(Err)); std::string ErrStr = toString(std::move(Err));
ODBG(OLDT_Init) << "Failure to check validity of image " << Image << ": " ODBG(OLDT_Init) << "Failure to check validity of image " << Image << ": "
<< ErrStr; << ErrStr;
return false; return false;
@@ -2069,7 +2069,7 @@ int32_t GenericPluginTy::use_auto_zero_copy(int32_t DeviceId) {
int32_t GenericPluginTy::is_accessible_ptr(int32_t DeviceId, const void *Ptr, int32_t GenericPluginTy::is_accessible_ptr(int32_t DeviceId, const void *Ptr,
size_t Size) { size_t Size) {
auto HandleError = [&](Error Err) -> bool { auto HandleError = [&](Error Err) -> bool {
[[maybe_unused]] std::string ErrStr = toString(std::move(Err)); std::string ErrStr = toString(std::move(Err));
ODBG(OLDT_Device) << "Failure while checking accessibility of pointer " ODBG(OLDT_Device) << "Failure while checking accessibility of pointer "
<< Ptr << " for device " << DeviceId << ": " << ErrStr; << Ptr << " for device " << DeviceId << ": " << ErrStr;
return false; return false;