[SystemZ] Limit depth of findCCUse() (#185922)

The recursion here has potentially exponential complexity. Avoid this by
limiting the depth of recursion.

An alternative would be to memoize the results. I went with the simpler
depth limit on the assumption that we don't particularly care about very
deep value chains here.

Fixes https://github.com/llvm/llvm-project/issues/185905.
This commit is contained in:
Nikita Popov
2026-03-12 09:00:38 +01:00
committed by GitHub
parent 90bb98cee9
commit 11e0d6ae4b

View File

@@ -8692,7 +8692,12 @@ SDValue SystemZTargetLowering::combineSETCC(
return SDValue();
}
static std::pair<SDValue, int> findCCUse(const SDValue &Val) {
static std::pair<SDValue, int> findCCUse(const SDValue &Val,
unsigned Depth = 0) {
// Limit depth of potentially exponential walk.
if (Depth > 5)
return std::make_pair(SDValue(), SystemZ::CCMASK_NONE);
switch (Val.getOpcode()) {
default:
return std::make_pair(SDValue(), SystemZ::CCMASK_NONE);
@@ -8705,7 +8710,7 @@ static std::pair<SDValue, int> findCCUse(const SDValue &Val) {
SDValue Op4CCReg = Val.getOperand(4);
if (Op4CCReg.getOpcode() == SystemZISD::ICMP ||
Op4CCReg.getOpcode() == SystemZISD::TM) {
auto [OpCC, OpCCValid] = findCCUse(Op4CCReg.getOperand(0));
auto [OpCC, OpCCValid] = findCCUse(Op4CCReg.getOperand(0), Depth + 1);
if (OpCC != SDValue())
return std::make_pair(OpCC, OpCCValid);
}
@@ -8722,10 +8727,10 @@ static std::pair<SDValue, int> findCCUse(const SDValue &Val) {
case ISD::SHL:
case ISD::SRA:
case ISD::SRL:
auto [Op0CC, Op0CCValid] = findCCUse(Val.getOperand(0));
auto [Op0CC, Op0CCValid] = findCCUse(Val.getOperand(0), Depth + 1);
if (Op0CC != SDValue())
return std::make_pair(Op0CC, Op0CCValid);
return findCCUse(Val.getOperand(1));
return findCCUse(Val.getOperand(1), Depth + 1);
}
}