81a537e708
This PR replaces the Get*CallbackAtIndex pattern in the PluginManager with returning a snapshot of callbacks that the caller can iterate over using a range-based for loop. This is a continuation of #184452 which added thread safety by using snapshots. However, that introduced a bunch of unnecessary copies which are largely eliminated again by getting the snapshot once when gather all the callbacks, rather than doing that on each iteration when querying a plugin for a given index. It also eliminates the possibility of the snapshot changing underneath you when iterating over the plugins. This change was largely mechanical and I used Claude to do the menial work of updating the signatures and call sites.
49 lines
1.6 KiB
C++
49 lines
1.6 KiB
C++
//===-- OperatingSystem.cpp -----------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Target/OperatingSystem.h"
|
|
#include "lldb/Core/PluginManager.h"
|
|
#include "lldb/Target/Thread.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
OperatingSystem *OperatingSystem::FindPlugin(Process *process,
|
|
const char *plugin_name) {
|
|
OperatingSystemCreateInstance create_callback = nullptr;
|
|
if (plugin_name) {
|
|
create_callback =
|
|
PluginManager::GetOperatingSystemCreateCallbackForPluginName(
|
|
plugin_name);
|
|
if (create_callback) {
|
|
std::unique_ptr<OperatingSystem> instance_up(
|
|
create_callback(process, true));
|
|
if (instance_up)
|
|
return instance_up.release();
|
|
}
|
|
} else {
|
|
for (auto create_callback :
|
|
PluginManager::GetOperatingSystemCreateCallbacks()) {
|
|
std::unique_ptr<OperatingSystem> instance_up(
|
|
create_callback(process, false));
|
|
if (instance_up)
|
|
return instance_up.release();
|
|
}
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
OperatingSystem::OperatingSystem(Process *process) : m_process(process) {}
|
|
|
|
bool OperatingSystem::IsOperatingSystemPluginThread(
|
|
const lldb::ThreadSP &thread_sp) {
|
|
if (thread_sp)
|
|
return thread_sp->IsOperatingSystemPluginThread();
|
|
return false;
|
|
}
|