394a3b9ced
While lowering phi-nodes to copies, subsequently to f7a53d82c0,
ensure that such copies are placed before any INLINEASM_BR
instructions, only if this actually happens to be the case.
If a block with an INLINEASM_BR instruction and any of its
indirect jump target are distinct blocks, the new copy on
the indirect target continues to be normally emitted prior
to the terminator.
Fixes: https://github.com/llvm/llvm-project/issues/172824.
81 lines
3.2 KiB
C++
81 lines
3.2 KiB
C++
//===-- PHIEliminationUtils.cpp - Helper functions for PHI elimination ----===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "PHIEliminationUtils.h"
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
|
|
using namespace llvm;
|
|
|
|
// Returns true if MBB contains an INLINEASM_BR instruction that may
|
|
// branch to SuccMBB, requiring specialized copy placement.
|
|
static bool hasInlineAsmBrToSuccessor(MachineBasicBlock *MBB,
|
|
MachineBasicBlock *SuccMBB) {
|
|
if (!SuccMBB->isInlineAsmBrIndirectTarget())
|
|
return false;
|
|
|
|
for (const MachineInstr &MI : reverse(*MBB))
|
|
if (MI.getOpcode() == TargetOpcode::INLINEASM_BR)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
// findCopyInsertPoint - Find a safe place in MBB to insert a copy from SrcReg
|
|
// when following the CFG edge to SuccMBB. This needs to be after any def of
|
|
// SrcReg, but before any subsequent point where control flow might jump out of
|
|
// the basic block.
|
|
MachineBasicBlock::iterator
|
|
llvm::findPHICopyInsertPoint(MachineBasicBlock* MBB, MachineBasicBlock* SuccMBB,
|
|
Register SrcReg) {
|
|
// Handle the trivial case trivially.
|
|
if (MBB->empty())
|
|
return MBB->begin();
|
|
|
|
// Usually, we just want to insert the copy before the first terminator
|
|
// instruction. However, for the edge going to a landing pad, we must insert
|
|
// the copy before the call/invoke instruction. Similarly for an INLINEASM_BR
|
|
// going to an indirect target. This is similar to SplitKit.cpp's
|
|
// computeLastInsertPoint, and similarly assumes that there cannot be multiple
|
|
// instructions that are Calls with EHPad successors or INLINEASM_BR in a
|
|
// block.
|
|
// Note that, if the successor basic block happens to be an indirect target,
|
|
// and the current block, which may be the successor itself, does not contain
|
|
// any INLINEASM_BR, we may not need any specialized handling.
|
|
bool EHPadSuccessor = SuccMBB->isEHPad();
|
|
if (!EHPadSuccessor && !hasInlineAsmBrToSuccessor(MBB, SuccMBB))
|
|
return MBB->getFirstTerminator();
|
|
|
|
// Discover any defs in this basic block.
|
|
SmallPtrSet<MachineInstr *, 8> DefsInMBB;
|
|
MachineRegisterInfo& MRI = MBB->getParent()->getRegInfo();
|
|
for (MachineInstr &RI : MRI.def_instructions(SrcReg))
|
|
if (RI.getParent() == MBB)
|
|
DefsInMBB.insert(&RI);
|
|
|
|
MachineBasicBlock::iterator InsertPoint = MBB->begin();
|
|
// Insert the copy at the _latest_ point of:
|
|
// 1. Immediately AFTER the last def
|
|
// 2. Immediately BEFORE a call/inlineasm_br.
|
|
for (auto I = MBB->rbegin(), E = MBB->rend(); I != E; ++I) {
|
|
if (DefsInMBB.contains(&*I)) {
|
|
InsertPoint = std::next(I.getReverse());
|
|
break;
|
|
}
|
|
if ((EHPadSuccessor && I->isCall()) ||
|
|
I->getOpcode() == TargetOpcode::INLINEASM_BR) {
|
|
InsertPoint = I.getReverse();
|
|
break;
|
|
}
|
|
}
|
|
|
|
// Make sure the copy goes after any phi nodes but before
|
|
// any debug nodes.
|
|
return MBB->SkipPHIsAndLabels(InsertPoint);
|
|
}
|