420d56a394
This was getting joined in ShutDownExcecptionThread (sic) but not cleared. So this function was not safe to call twice, since you aren't supposed to join a thread twice. Sadly, this was called in MachTask::Clear and MachProcess::Destroy, which are both called when you tell debugserver to detach. This didn't seem to cause problems IRL, but the most recent ASAN detects this as an error and calls ASAN::Die, which was causing all the tests that ran detach to fail. I fixed that by moving the clear & test for m_exception_thread to ShutDownExceptionThread. I also fixed the spelling of that routine. And that routine was claiming to return a kern_return_t which no one was checking. It actually returns a kern_return_t if there was a Mach failure and a Posix error if there was a join failure. Since there's really nothing you can do but exit if this fails, which is always what you are in the process of doing when you call this, and since we have already done all the useful logging in ShutDownExceptionThread, I just removed the return value.
119 lines
4.1 KiB
C++
119 lines
4.1 KiB
C++
//===-- MachTask.h ----------------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// MachTask.h
|
|
// debugserver
|
|
//
|
|
// Created by Greg Clayton on 12/5/08.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_TOOLS_DEBUGSERVER_SOURCE_MACOSX_MACHTASK_H
|
|
#define LLDB_TOOLS_DEBUGSERVER_SOURCE_MACOSX_MACHTASK_H
|
|
|
|
#include "DNBDefs.h"
|
|
#include "MachException.h"
|
|
#include "MachVMMemory.h"
|
|
#include "RNBContext.h"
|
|
#include <mach/mach.h>
|
|
#include <map>
|
|
#include <string>
|
|
#include <sys/socket.h>
|
|
|
|
class MachProcess;
|
|
|
|
typedef uint64_t MachMallocEventId;
|
|
|
|
enum MachMallocEventType {
|
|
eMachMallocEventTypeAlloc = 2,
|
|
eMachMallocEventTypeDealloc = 4,
|
|
eMachMallocEventTypeOther = 1
|
|
};
|
|
|
|
struct MachMallocEvent {
|
|
mach_vm_address_t m_base_address;
|
|
uint64_t m_size;
|
|
MachMallocEventType m_event_type;
|
|
MachMallocEventId m_event_id;
|
|
};
|
|
|
|
class MachTask {
|
|
public:
|
|
// Constructors and Destructors
|
|
MachTask(MachProcess *process);
|
|
virtual ~MachTask();
|
|
|
|
void Clear();
|
|
|
|
kern_return_t Suspend();
|
|
kern_return_t Resume();
|
|
|
|
nub_size_t ReadMemory(nub_addr_t addr, nub_size_t size, void *buf);
|
|
nub_size_t WriteMemory(nub_addr_t addr, nub_size_t size, const void *buf);
|
|
int GetMemoryRegionInfo(nub_addr_t addr, DNBRegionInfo *region_info);
|
|
nub_bool_t GetMemoryTags(nub_addr_t addr, nub_size_t size,
|
|
std::vector<uint8_t> &tags);
|
|
std::string GetProfileData(DNBProfileDataScanType scanType);
|
|
|
|
nub_addr_t AllocateMemory(nub_size_t size, uint32_t permissions);
|
|
nub_bool_t DeallocateMemory(nub_addr_t addr);
|
|
void ClearAllocations();
|
|
|
|
mach_port_t ExceptionPort() const;
|
|
bool ExceptionPortIsValid() const;
|
|
kern_return_t SaveExceptionPortInfo();
|
|
kern_return_t RestoreExceptionPortInfo();
|
|
void ShutDownExceptionThread();
|
|
|
|
bool StartExceptionThread(
|
|
const RNBContext::IgnoredExceptions &ignored_exceptions, DNBError &err);
|
|
nub_addr_t GetDYLDAllImageInfosAddress(DNBError &err);
|
|
kern_return_t BasicInfo(struct task_basic_info *info);
|
|
static kern_return_t BasicInfo(task_t task, struct task_basic_info *info);
|
|
bool IsValid() const;
|
|
static bool IsValid(task_t task);
|
|
static void *ExceptionThread(void *arg);
|
|
void TaskPortChanged(task_t task);
|
|
task_t TaskPort() const { return m_task; }
|
|
task_t TaskPortForProcessID(DNBError &err, bool force = false);
|
|
static task_t TaskPortForProcessID(pid_t pid, DNBError &err);
|
|
|
|
MachProcess *Process() { return m_process; }
|
|
const MachProcess *Process() const { return m_process; }
|
|
|
|
nub_size_t PageSize();
|
|
void TaskWillExecProcessesSuspended() { m_exec_will_be_suspended = true; }
|
|
|
|
protected:
|
|
MachProcess *m_process; // The mach process that owns this MachTask
|
|
task_t m_task;
|
|
MachVMMemory m_vm_memory; // Special mach memory reading class that will take
|
|
// care of watching for page and region boundaries
|
|
MachException::PortInfo
|
|
m_exc_port_info; // Saved settings for all exception ports
|
|
pthread_t m_exception_thread; // Thread ID for the exception thread in case we
|
|
// need it
|
|
mach_port_t m_exception_port; // Exception port on which we will receive child
|
|
// exceptions
|
|
bool m_exec_will_be_suspended; // If this task exec's another process, that
|
|
// process will be launched suspended and we will
|
|
// need to execute one extra Resume to get it
|
|
// to progress from dyld_start.
|
|
bool m_do_double_resume; // next time we task_resume(), do it twice to
|
|
// fix a too-high suspend count.
|
|
|
|
typedef std::map<mach_vm_address_t, size_t> allocation_collection;
|
|
allocation_collection m_allocations;
|
|
|
|
private:
|
|
MachTask(const MachTask &) = delete;
|
|
MachTask &operator=(const MachTask &rhs) = delete;
|
|
};
|
|
|
|
#endif // LLDB_TOOLS_DEBUGSERVER_SOURCE_MACOSX_MACHTASK_H
|