c64257b4b7
We stopped marking `__lldb_expr` with the function qualifiers of the method LLDB is stopped in ever since `8bdcd522510f923185cdfaec66c4a78d0a0d38c0`. The assumption was that it wasn't ever required for correctness (i.e., LLDB should just always pretend it's in a mutable context). But since function qualifiers affect overloading in C++, this assumption can lead to unexpected expression evaluator behaviour. E.g., if a function is overloaded on qualifiers (`const` vs. `non-const`), the expression evaluator would currently always call the non-CV qualified overload. This patch adds function qualifiers to `$__lldb_class::$__lldb_expr` that resemble the qualifiers of the method that we're stopped in. However, mutating variables or calling arbitrary member functions from CV-qualified methods can be useful/is something users already may be used to. To provide users with the ability to ignore the CV-qualifiers of the current context, we will provide an expression evaluator flag that switches this off in a follow-up patch.
59 lines
2.0 KiB
Python
59 lines
2.0 KiB
Python
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TestCase(TestBase):
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def run_class_tests(self):
|
|
# Expression not referencing context class.
|
|
self.expect_expr("1 + 1", result_type="int", result_value="2")
|
|
# Referencing context class.
|
|
self.expect_expr("member", result_type="const int", result_value="3")
|
|
# Check the type of context class.
|
|
self.expect_expr("this", result_type="const ContextClass *")
|
|
|
|
def test_member_func(self):
|
|
self.build()
|
|
lldbutil.run_to_source_breakpoint(
|
|
self, "// break in function in class.", lldb.SBFileSpec("main.cpp")
|
|
)
|
|
self.run_class_tests()
|
|
|
|
def test_templated_member_func(self):
|
|
self.build()
|
|
lldbutil.run_to_source_breakpoint(
|
|
self,
|
|
"// break in templated function in class.",
|
|
lldb.SBFileSpec("main.cpp"),
|
|
)
|
|
self.run_class_tests()
|
|
|
|
def run_template_class_tests(self):
|
|
# Expression not referencing context class.
|
|
self.expect_expr("1 + 1", result_type="int", result_value="2")
|
|
# Referencing context class.
|
|
self.expect_expr("member", result_type="const int", result_value="4")
|
|
# Check the type of context class.
|
|
self.expect_expr("this", result_type="const TemplatedContextClass<int> *")
|
|
|
|
def test_template_member_func(self):
|
|
self.build()
|
|
lldbutil.run_to_source_breakpoint(
|
|
self,
|
|
"// break in function in templated class.",
|
|
lldb.SBFileSpec("main.cpp"),
|
|
)
|
|
self.run_template_class_tests()
|
|
|
|
def test_template_templated_member_func(self):
|
|
self.build()
|
|
lldbutil.run_to_source_breakpoint(
|
|
self,
|
|
"// break in templated function in templated class.",
|
|
lldb.SBFileSpec("main.cpp"),
|
|
)
|
|
self.run_template_class_tests()
|