81a537e708
This PR replaces the Get*CallbackAtIndex pattern in the PluginManager with returning a snapshot of callbacks that the caller can iterate over using a range-based for loop. This is a continuation of #184452 which added thread safety by using snapshots. However, that introduced a bunch of unnecessary copies which are largely eliminated again by getting the snapshot once when gather all the callbacks, rather than doing that on each iteration when querying a plugin for a given index. It also eliminates the possibility of the snapshot changing underneath you when iterating over the plugins. This change was largely mechanical and I used Claude to do the menial work of updating the signatures and call sites.
28 lines
956 B
C++
28 lines
956 B
C++
//===-- UnwindAssembly.cpp ------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Target/UnwindAssembly.h"
|
|
#include "lldb/Core/PluginInterface.h"
|
|
#include "lldb/Core/PluginManager.h"
|
|
#include "lldb/lldb-private.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
UnwindAssemblySP UnwindAssembly::FindPlugin(const ArchSpec &arch) {
|
|
for (auto create_callback :
|
|
PluginManager::GetUnwindAssemblyCreateCallbacks()) {
|
|
UnwindAssemblySP assembly_profiler_up(create_callback(arch));
|
|
if (assembly_profiler_up)
|
|
return assembly_profiler_up;
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
UnwindAssembly::UnwindAssembly(const ArchSpec &arch) : m_arch(arch) {}
|