d714a6c210
This reverts commit
54a4da9df6.
MSVC supports an extension allowing to delete an array of objects via
pointer whose static type doesn't match its dynamic type. This is done
via generation of special destructors - vector deleting destructors.
MSVC's virtual tables always contain a pointer to the vector deleting
destructor for classes with virtual destructors, so not having this
extension implemented causes clang to generate code that is not
compatible with the code generated by MSVC, because clang always puts a
pointer to a scalar deleting destructor to the vtable. As a bonus the
deletion of an array of polymorphic object will work just like it does
with MSVC - no memory leaks and correct destructors are called.
This patch will cause clang to emit code that is compatible with code
produced by MSVC but not compatible with code produced with clang of
older versions, so the new behavior can be disabled via passing
-fclang-abi-compat=21 (or lower).
Fixes https://github.com/llvm/llvm-project/issues/19772
161 lines
4.8 KiB
C++
161 lines
4.8 KiB
C++
// RUN: %clang_cc1 -fno-rtti -emit-llvm %s -o - -triple=i386-pc-win32 >%t 2>&1
|
|
// RUN: FileCheck --check-prefix=MANGLING %s < %t
|
|
// RUN: FileCheck --check-prefix=XMANGLING %s < %t
|
|
// RUN: FileCheck --check-prefix=CODEGEN %s < %t
|
|
// RUN: %clang_cc1 -fno-rtti -emit-llvm %s -o - -triple=x86_64-pc-win32 2>&1 | FileCheck --check-prefix=MANGLING-X64 %s
|
|
|
|
void foo(void *);
|
|
|
|
struct A {
|
|
virtual ~A();
|
|
virtual void public_f();
|
|
// Make sure we don't emit unneeded thunks:
|
|
// XMANGLING-NOT: @"?public_f@A@@QAEXXZ"
|
|
protected:
|
|
virtual void protected_f();
|
|
private:
|
|
virtual void private_f();
|
|
};
|
|
|
|
struct B {
|
|
virtual ~B();
|
|
virtual void public_f();
|
|
protected:
|
|
virtual void protected_f();
|
|
private:
|
|
virtual void private_f();
|
|
};
|
|
|
|
|
|
struct C : A, B {
|
|
C();
|
|
|
|
virtual ~C();
|
|
// MANGLING-DAG: declare {{.*}} @"??1C@@UAE@XZ"({{.*}})
|
|
// MANGLING-DAG: define {{.*}} @"??_GC@@UAEPAXI@Z"({{.*}})
|
|
// MANGLING-DAG: define {{.*}} @"??_EC@@W3AEPAXI@Z"({{.*}}) {{.*}} comdat
|
|
// MANGLING-X64-DAG: declare {{.*}} @"??1C@@UEAA@XZ"({{.*}})
|
|
// MANGLING-X64-DAG: define {{.*}} @"??_GC@@UEAAPEAXI@Z"({{.*}})
|
|
// MANGLING-X64-DAG: define {{.*}} @"??_EC@@W7EAAPEAXI@Z"({{.*}}) {{.*}} comdat
|
|
|
|
// Overrides public_f() of two subobjects with distinct vfptrs, thus needs a thunk.
|
|
virtual void public_f();
|
|
// MANGLING-DAG: @"?public_f@C@@UAEXXZ"
|
|
// MANGLING-DAG: @"?public_f@C@@W3AEXXZ"
|
|
// MANGLING-X64-DAG: @"?public_f@C@@UEAAXXZ"
|
|
// MANGLING-X64-DAG: @"?public_f@C@@W7EAAXXZ"
|
|
protected:
|
|
virtual void protected_f();
|
|
// MANGLING-DAG: @"?protected_f@C@@MAEXXZ"
|
|
// MANGLING-DAG: @"?protected_f@C@@O3AEXXZ"
|
|
// MANGLING-X64-DAG: @"?protected_f@C@@MEAAXXZ"
|
|
// MANGLING-X64-DAG: @"?protected_f@C@@O7EAAXXZ"
|
|
|
|
private:
|
|
virtual void private_f();
|
|
// MANGLING-DAG: @"?private_f@C@@EAEXXZ"
|
|
// MANGLING-DAG: @"?private_f@C@@G3AEXXZ"
|
|
// MANGLING-X64-DAG: @"?private_f@C@@EEAAXXZ"
|
|
// MANGLING-X64-DAG: @"?private_f@C@@G7EAAXXZ"
|
|
};
|
|
|
|
C::C() {} // Emits vftable and forces thunk generation.
|
|
|
|
// CODEGEN-LABEL: define linkonce_odr dso_local x86_thiscallcc noundef ptr @"??_EC@@W3AEPAXI@Z"(ptr noundef %this, i32 noundef %should_call_delete) {{.*}} comdat
|
|
// CODEGEN: getelementptr i8, ptr {{.*}}, i32 -4
|
|
// CODEGEN: call x86_thiscallcc noundef ptr @"??_EC@@UAEPAXI@Z"
|
|
// CODEGEN: ret
|
|
|
|
// CODEGEN-LABEL: define linkonce_odr dso_local x86_thiscallcc void @"?public_f@C@@W3AEXXZ"(ptr
|
|
// CODEGEN: getelementptr i8, ptr {{.*}}, i32 -4
|
|
// CODEGEN: call x86_thiscallcc void @"?public_f@C@@UAEXXZ"(ptr
|
|
// CODEGEN: ret
|
|
|
|
void zoo(C* obj) {
|
|
delete obj;
|
|
}
|
|
|
|
struct D {
|
|
virtual B* goo();
|
|
};
|
|
|
|
struct E : D {
|
|
E();
|
|
virtual C* goo();
|
|
// MANGLING-DAG: @"?goo@E@@UAEPAUC@@XZ"
|
|
// MANGLING-DAG: @"?goo@E@@QAEPAUB@@XZ"
|
|
// MANGLING-X64-DAG: @"?goo@E@@UEAAPEAUC@@XZ"
|
|
// MANGLING-X64-DAG: @"?goo@E@@QEAAPEAUB@@XZ"
|
|
};
|
|
|
|
E::E() {} // Emits vftable and forces thunk generation.
|
|
|
|
// CODEGEN-LABEL: define weak_odr dso_local x86_thiscallcc noundef ptr @"?goo@E@@QAEPAUB@@XZ"{{.*}} comdat
|
|
// CODEGEN: call x86_thiscallcc noundef ptr @"?goo@E@@UAEPAUC@@XZ"
|
|
// CODEGEN: getelementptr inbounds i8, ptr {{.*}}, i32 4
|
|
// CODEGEN: ret
|
|
|
|
struct F : virtual A, virtual B {
|
|
virtual void own_method();
|
|
virtual ~F();
|
|
};
|
|
|
|
F f; // Just make sure we don't crash, e.g. mangling the complete dtor.
|
|
|
|
struct G : C { };
|
|
|
|
struct H : E {
|
|
virtual G* goo();
|
|
// MANGLING-DAG: @"?goo@H@@UAEPAUG@@XZ"
|
|
// MANGLING-DAG: @"?goo@H@@QAEPAUB@@XZ"
|
|
// MANGLING-DAG: @"?goo@H@@QAEPAUC@@XZ"
|
|
// MANGLING-X64-DAG: @"?goo@H@@UEAAPEAUG@@XZ"
|
|
// MANGLING-X64-DAG: @"?goo@H@@QEAAPEAUB@@XZ"
|
|
// MANGLING-X64-DAG: @"?goo@H@@QEAAPEAUC@@XZ"
|
|
};
|
|
|
|
H h;
|
|
|
|
struct I : D {
|
|
I();
|
|
virtual F* goo();
|
|
};
|
|
|
|
I::I() {} // Emits vftable and forces thunk generation.
|
|
|
|
// CODEGEN-LABEL: define weak_odr dso_local x86_thiscallcc noundef ptr @"?goo@I@@QAEPAUB@@XZ"{{.*}} comdat
|
|
// CODEGEN: %[[ORIG_RET:.*]] = call x86_thiscallcc noundef ptr @"?goo@I@@UAEPAUF@@XZ"
|
|
// CODEGEN: %[[VBPTR_i8:.*]] = getelementptr inbounds i8, ptr %[[ORIG_RET]], i32 4
|
|
// CODEGEN: %[[VBTABLE:.*]] = load ptr, ptr %[[VBPTR_i8]]
|
|
// CODEGEN: %[[VBASE_OFFSET_PTR:.*]] = getelementptr inbounds i32, ptr %[[VBTABLE]], i32 2
|
|
// CODEGEN: %[[VBASE_OFFSET:.*]] = load i32, ptr %[[VBASE_OFFSET_PTR]]
|
|
// CODEGEN: %[[RES_i8:.*]] = getelementptr inbounds i8, ptr %[[VBPTR_i8]], i32 %[[VBASE_OFFSET]]
|
|
// CODEGEN: phi ptr {{.*}} %[[RES_i8]]
|
|
// CODEGEN: ret ptr
|
|
|
|
namespace CrashOnThunksForAttributedType {
|
|
// We used to crash on this because the type of foo is an AttributedType, not
|
|
// FunctionType, and we had to look through the sugar.
|
|
struct A {
|
|
virtual void __stdcall foo();
|
|
};
|
|
struct B {
|
|
virtual void __stdcall foo();
|
|
};
|
|
struct C : A, B {
|
|
virtual void __stdcall foo();
|
|
};
|
|
C c;
|
|
}
|
|
|
|
namespace {
|
|
struct E : D {
|
|
E();
|
|
virtual C* goo();
|
|
};
|
|
E::E() {}
|
|
E e;
|
|
// Class with internal linkage has internal linkage thunks.
|
|
// CODEGEN: define internal x86_thiscallcc noundef ptr @"?goo@E@?A0x{{[^@]*}}@@QAEPAUB@@XZ"
|
|
}
|