From efee326373545d6decf69a3df7c216a40cdcf2ec Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Mon, 17 Nov 2025 16:24:12 -0800 Subject: [PATCH] [CI] Gracefully Fail when Job Completion Timestamp is None (#168457) There seem to be cases where the workflow status is completed but the jobs have not completed. We need to gracefully handle these changes to avoid a crash loop in the metrics container. --- .ci/metrics/metrics.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.ci/metrics/metrics.py b/.ci/metrics/metrics.py index a6d6edbd547e..ac39a47d43c0 100644 --- a/.ci/metrics/metrics.py +++ b/.ci/metrics/metrics.py @@ -370,6 +370,13 @@ def github_get_metrics( started_at = job.started_at completed_at = job.completed_at + if completed_at is None: + logging.info( + f"Workflow {task.id} is marked completed but has a job without a " + "completion timestamp." + ) + continue + # GitHub API can return results where the started_at is slightly # later then the created_at (or completed earlier than started). # This would cause a -23h59mn delta, which will show up as +24h