From 9b8611b1c5b3d454b2c5e052c00f7285d733d496 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Wed, 15 Apr 2026 10:42:28 +0800 Subject: [PATCH] [OpenMP] Create check-openmp target for device targets (#192175) offload/cmake/caches/AMDGPUBot.cmake enables RUNTIMES_amdgcn-amd-amdhsa_LLVM_ENABLE_RUNTIMES="openmp". In that sub-build, check-openmp target doesn't exist and there is build error `unknown target 'check-openmp'` after 18f63d1375d0, which makes top-level check-openmp depend on check-openmp-amdgcn-amd-amdhsa. In openmp, the device targets only call add_subdirectory(device), which doesn't calls construct_check_openmp_target() and check-openmp target doesn't exist. `ninja check-openmp-amdgcn-amd-amdhsa` also fails with the same error before 18f63d1375d0. Fix by adding construct_check_openmp_target() for device targets as well. Assisted-by: Claude Sonnet 4.6 --- openmp/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/openmp/CMakeLists.txt b/openmp/CMakeLists.txt index 3c358f840343..ff2bfba240e5 100644 --- a/openmp/CMakeLists.txt +++ b/openmp/CMakeLists.txt @@ -173,7 +173,7 @@ else() # Build documentation add_subdirectory(docs) - - # Now that we have seen all testsuites, create the check-openmp target. - construct_check_openmp_target() endif() + +# Now that we have seen all testsuites, create the check-openmp target. +construct_check_openmp_target()