Doomhowl-Interactive/llvm-project
0
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

[UnitTests] Enable PCH (#191402)

Browse Source 
I originally didn't enable PCH for unit tests, because I intended to
build a gtest PCH. But while gtest.h is slow, having many large standard
library headers already pre-compiled via the LLVMSupport PCH already
helps a lot, leaving ~250ms for parsing gtest.h (+ a fair amount of time
for template instantiation). Additionally, for unit tests that include
IR or AST headers, re-using the PCHs that include these is more
beneficial than gtest.h. Therefore, no longer disable PCH on unit tests.
This commit is contained in:
Alexis Engelke
2026-04-10 22:11:01 +02:00
committed by GitHub
parent ae7f902429
commit 47eb8b43c9
4 changed files with 3 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
clang/unittests/Basic/CharInfoTest.cpp
View File

@@ -9,7 +9,6 @@
#include "clang/Basic/CharInfo.h"
#include "gtest/gtest.h"
using namespace llvm;
using namespace clang;
// Check that the CharInfo table has been constructed reasonably.

2
clang/unittests/Frontend/CompilerInstanceTest.cpp
View File

@@ -173,7 +173,7 @@ TEST(CompilerInstance, SingleModuleParseModeCallback) {
std::vector<std::string> &SkippedModules;
ModuleLoadSkippedCallback(std::vector<std::string> &SkippedModules)
: SkippedModules(SkippedModules) {}
void moduleLoadSkipped(Module *Skipped) override {
void moduleLoadSkipped(clang::Module *Skipped) override {
SkippedModules.emplace_back(Skipped->getFullModuleName());
}
};

2
llvm/cmake/modules/AddLLVM.cmake
View File

@@ -1906,7 +1906,7 @@ function(add_unittest test_suite test_name)
endif()
list(APPEND LLVM_LINK_COMPONENTS Support) # gtest needs it for raw_ostream
add_llvm_executable(${test_name} IGNORE_EXTERNALIZE_DEBUGINFO NO_INSTALL_RPATH DISABLE_PCH_REUSE ${ARGN})
add_llvm_executable(${test_name} IGNORE_EXTERNALIZE_DEBUGINFO NO_INSTALL_RPATH ${ARGN})
get_subproject_title(subproject_title)
set_target_properties(${test_name} PROPERTIES FOLDER "${subproject_title}/Tests/Unit")

15
llvm/unittests/Support/raw_sha1_ostream_test.cpp
View File

@@ -6,6 +6,7 @@
//
//===----------------------------------------------------------------------===//
#include "llvm/ADT/StringExtras.h"
#include "llvm/Support/Format.h"
#include "llvm/Support/raw_sha1_ostream.h"
#include "gtest/gtest.h"
@@ -14,20 +15,6 @@
using namespace llvm;
static std::string toHex(ArrayRef<uint8_t> Input) {
static const char *const LUT = "0123456789ABCDEF";
size_t Length = Input.size();
std::string Output;
Output.reserve(2 * Length);
for (size_t i = 0; i < Length; ++i) {
const unsigned char c = Input[i];
Output.push_back(LUT[c >> 4]);
Output.push_back(LUT[c & 15]);
}
return Output;
}
TEST(raw_sha1_ostreamTest, Basic) {
llvm::raw_sha1_ostream Sha1Stream;
Sha1Stream << "Hello World!";