Doomhowl-Interactive/llvm-project
0
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

llvm: Use add_link_options for stack size flags (#195034)

Browse Source 
Previously, LLVM was directly editing `CMAKE_EXE_LINKER_FLAGS`. This is
a user-facing CMake cache variable not meant to be modified by project
code. This was causing issues for downstream consumers building
non-C/C++ targets as part of the LLVM build.

Modern CMake provides `add_link_options()`, a cleaner way to set linker
flags that propagate to every target in a directory tree.

Generator expressions and the `LINKER:` prefix syntax ensure that this
is only applied to executable targets with the proper language and
linker argument wrapping.
This commit is contained in:
Fabrice de Gans
2026-04-30 09:04:28 +00:00
committed by GitHub
parent 124ab73043
commit 4354248d10
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/cmake/modules/HandleLLVMOptions.cmake
View File

@@ -570,14 +570,15 @@ if( MSVC_IDE )
endif() endif()
# set stack reserved size to ~10MB # set stack reserved size to ~10MB
set(_is_exe "$<STREQUAL:$<TARGET_PROPERTY:TYPE>,EXECUTABLE>")
if(MSVC) if(MSVC)
# CMake previously automatically set this value for MSVC builds, but the # CMake previously automatically set this value for MSVC builds, but the
# behavior was changed in CMake 2.8.11 (Issue 12437) to use the MSVC default # behavior was changed in CMake 2.8.11 (Issue 12437) to use the MSVC default
# value (1 MB) which is not enough for us in tasks such as parsing recursive # value (1 MB) which is not enough for us in tasks such as parsing recursive
# C++ templates in Clang. # C++ templates in Clang.
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${CMAKE_CXX_LINKER_WRAPPER_FLAG}/STACK:10000000") add_link_options("$<${_is_exe}:LINKER:/STACK:10000000>")
elseif(MINGW OR CYGWIN) elseif(MINGW OR CYGWIN)
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--stack,16777216") add_link_options("$<${_is_exe}:LINKER:--stack,16777216>")
# Pass -mbig-obj to mingw gas to avoid COFF 2**16 section limit. # Pass -mbig-obj to mingw gas to avoid COFF 2**16 section limit.
if (NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang") if (NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")